Add xmake.lua for qt6quickcontrols2 package by std-microblock · Pull Request #9304 · xmake-io/xmake-repo

std-microblock · 2026-02-09T12:41:38Z

Before adding new features and new modules, please go to issues to submit the relevant feature description first.
Write good commit messages and use the same coding conventions as the rest of the project.
Please commit code to dev branch and we will merge into master branch in feature
Ensure your edited codes with four spaces instead of TAB.

增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。

gemini-code-assist · 2026-02-09T12:42:49Z

Summary of Changes

Hello @std-microblock, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new package definition for qt6quickcontrols2 within the xmake build system. It configures the necessary dependencies, compilation flags, and a test function to ensure the package is correctly set up and functional across different platforms.

Highlights

New Package Definition: Adds a new package definition for qt6quickcontrols2 to the xmake build system.
Dependency Management: Specifies dependencies on other Qt6 modules such as qt6quick, qt6qml, qt6gui, and qt6core.
Platform-Specific Compilation Flags: Includes platform-specific compilation flags, such as /Zc:__cplusplus and /permissive- for Windows, and -fPIC for other platforms.
C++17 Support: Enables C++17 language support for the package.
Test Functionality: Adds a test function to verify the correct setup of the QQuickStyle.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

packages/q/qt6quickcontrols2/xmake.lua
- Added a new package definition for qt6quickcontrols2.
- Configured dependencies on qt6quick, qt6qml, qt6gui, and qt6core.
- Implemented platform-specific compilation flags for Windows and other platforms.
- Enabled C++17 language support.
- Added a test function to verify QQuickStyle setup.

Activity

New file added: packages/q/qt6quickcontrols2/xmake.lua.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new xmake package definition for qt6quickcontrols2. The implementation is solid and aligns well with the existing Qt6 packages. I have a couple of suggestions to improve maintainability and consistency, which are detailed in the comments below.

gemini-code-assist · 2026-02-09T12:43:36Z

packages/q/qt6quickcontrols2/xmake.lua

+    set_kind("library")
+
+    on_load(function (package)
+        package:add("deps", "qt6quick", "qt6qml", "qt6gui", "qt6core", {debug = package:is_debug(), version = package:version_str()})


The dependencies qt6qml, qt6gui, and qt6core are transitive dependencies of qt6quick. You can simplify this declaration by only listing qt6quick as a direct dependency. This improves maintainability by relying on the dependency graph already defined in the qt6quick package.

package:add("deps", "qt6quick", {debug = package:is_debug(), version = package:version_str()})

gemini-code-assist · 2026-02-09T12:43:36Z

packages/q/qt6quickcontrols2/xmake.lua

+        if package:is_plat("windows") then
+            cxflags = {"/Zc:__cplusplus", "/permissive-"}
+        else
+            cxflags = "-fPIC"


For consistency, cxflags should always be a table of strings. The Windows-specific flags on line 15 are correctly defined as a table. This branch should do the same to ensure the cxflags variable has a consistent type, which is better practice even if xmake can handle a string value.

cxflags = {"-fPIC"}

Removed installation function for specific platforms.

waruqi · 2026-02-12T04:57:33Z

packages/q/qt6quickcontrols2/xmake.lua

+        }))
+    end)
+
+    on_install("windows|x64,linux|x86_64,linux|arm64,macosx,mingw|x86_64@windows,linux,macosx", function (package)


? remove it. see other qt6xxx packages

waruqi · 2026-02-12T04:57:47Z

packages/q/qt6quickcontrols2/xmake.lua

+        package:base():script("load")(package)
+    end)
+
+    on_test(function (package)


move on_test to the bottom

Add xmake.lua for qt6quickcontrols2 package

9318e56

gemini-code-assist bot reviewed Feb 9, 2026

View reviewed changes

std-microblock added 2 commits February 12, 2026 12:01

Add installation checks for various platforms

47bb978

Remove on_install function for certain platforms

da335eb

Removed installation function for specific platforms.

waruqi reviewed Feb 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add xmake.lua for qt6quickcontrols2 package#9304

Add xmake.lua for qt6quickcontrols2 package#9304
std-microblock wants to merge 3 commits intoxmake-io:devfrom
std-microblock:patch-22

std-microblock commented Feb 9, 2026

Uh oh!

gemini-code-assist bot commented Feb 9, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Feb 9, 2026

Uh oh!

gemini-code-assist bot Feb 9, 2026

Uh oh!

waruqi Feb 12, 2026

Uh oh!

waruqi Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

std-microblock commented Feb 9, 2026

Uh oh!

gemini-code-assist bot commented Feb 9, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

waruqi Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

waruqi Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants